search

adoptium / temurin-build

Eclipse Temurin™ build scripts - common across all releases/versions
Apache License 2.0
1.02k stars 249 forks source link

Update rendering library to be consistent with other vendors of OpenJDK #1119

Open Mekadrom opened 5 years ago

Mekadrom commented 5 years ago

After a brief conversation with others in the AdoptOpenJDK slack, I decided to open a ticket with an example of the differences between AdoptOpenJDK's chosen rendering native library and those of other OpenJDK vendors.

image

Note: Yes, the AdoptOpenJDK title bar size is now consistent with the default Windows title bar size. However, I don't believe that this is supposed to be the case. The windows pictured use the same exact code and that code extends JDialog.

The solution for this would be to implement the same or a similar native rendering library to the other vendors of OpenJDK.

If I need to add anything to this issue tracker, please let me know. I have no experience with this sort of thing and I actually have no clue what this whole native rendering library thing means, I'm just parroting martijnverburg from slack.

karianna commented 5 years ago

Related: https://github.com/AdoptOpenJDK/openjdk-build/issues/716 and https://github.com/AdoptOpenJDK/openjdk-build/issues/835

gdams commented 5 years ago

@Mekadrom what java version are you using? Is this a fonts issue or a rendering issue?

Mekadrom commented 5 years ago

@gdams This would be in 1.8u212b03, the change was noticed after upgrading from 1.8u181.

bourgesl commented 4 years ago

I prepared patches to backport the Marlin renderer 0.9.1.3 (like jdk14) to OpenJDK8 (jdk8u-dev). See https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-November/010549.html See my github repo: https://github.com/bourgesl/marlin-jdk8u Enjoy FOSS Marlin renderer, Laurent

karianna commented 4 years ago

Needs discussing at @AdoptOpenJDK/tsc level

karianna commented 4 years ago

https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-May/011635.html shows the progress of the patch that @bourgesl is working on. We'll effectively wait for that to land upstream.

bourgesl commented 4 years ago

Status of Marlin renderer backport to jdk8u-dev:

See up-to-date status: https://github.com/bourgesl/marlin-jdk8u/blob/master/README.md

karianna commented 4 years ago

Status of Marlin renderer backport to jdk8u-dev:

  • partial integration in 8u252: DO NOT USE IN PRODUCTION = 9/21 patches integrated = 0.7.3.2 release (june 2015) = pre-jdk9 release
  • partial integration in 8u262 or 8u-dev: DO NOT USE IN PRODUCTION = 10/21 patches integrated = 0.7.3.3 release (june 2015) = pre-jdk9 release

See up-to-date status: https://github.com/bourgesl/marlin-jdk8u/blob/master/README.md

Thanks for your tireless work in getting this resolved!