search

adoptium / temurin-build

Eclipse Temurin™ build scripts - common across all releases/versions
Apache License 2.0
1.02k stars 247 forks source link

JDK8 java.vendor, java.vm.vendor values #2664

Open sophia-guo opened 3 years ago

sophia-guo commented 3 years ago

Smoke tests shows that JDK8 java.vendor, java.vm.vendor = Temurin And JDK11 java.vendor, java.vm.vendor = Eclipse Foundation

Is this expected?

JDK8:

    java.vendor = Temurin
    java.vendor.url = https://adoptium.net/
    java.vendor.url.bug = https://github.com/adoptium/adoptium-support/issues
    java.version = 1.8.0_302-beta
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 1.8
    java.vm.vendor = Temurin

jdk11:

    java.vendor.url = https://adoptium.net/
    java.vendor.url.bug = https://github.com/adoptium/adoptium-support/issues
    java.vendor.version = Temurin-11.0.12+5-202106151809
    java.version = 11.0.12-beta
    java.version.date = 2021-07-20
    java.vm.compressedOopsMode = Zero based
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 11
    java.vm.vendor = Eclipse Foundation

java.vendor = Temurin will make no smoke tests run against the jdk as smoke test set as 

         <vendors>
            <vendor>eclipse</vendor>
        </vendors>
mlopatkin commented 3 years ago

Are there any updates about this issue? Certain features of the Gradle build system rely on the vendor strings and it will be great to know if the inconsistency is intentional or how it will be resolved.

karianna commented 3 years ago

We respun the 8 binaries with the corrected vendor, please re-download the Java 8 build, should be fixed!

mlopatkin commented 3 years ago

Thank you for the fast reply!

We respun the 8 binaries with the corrected vendor, please re-download the Java 8 build, should be fixed!

So I assume that the Eclipse Foundation is the right one, isn't it?

I've checked the version available at https://adoptium.net/?variant=openjdk8&jvmVariant=hotspot. It still uses Temurin as a java.vendor. Same for the recent builds from https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/. I've only checked linux-x64 builds though.

karianna commented 2 years ago

Thank you for the fast reply!

We respun the 8 binaries with the corrected vendor, please re-download the Java 8 build, should be fixed!

So I assume that the Eclipse Foundation is the right one, isn't it?

I've checked the version available at https://adoptium.net/?variant=openjdk8&jvmVariant=hotspot. It still uses Temurin as a java.vendor. Same for the recent builds from https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/. I've only checked linux-x64 builds though.

OK, so we got that change wrong. A new #2705 will resolve this, but we may not respin until Oct PSU as it's a global change to Eclipse Adoptium as a vendor (I'll link to the published PMC minutes on this decision later on)