Open sophia-guo opened 4 weeks ago
@sophia-guo the re-build is not specifying BUILD_ARG --build-reproducible-date "\<Build Timestamp value from SBOM>",
However, I don't think that will totally fix it, as Windows does a double-build due to the Signing, and I think the SBOM "Build Timestamp" maybe wrong, as I think it gets set from the 2nd build value, but the value actually compiled in is from the 1st build. To fix that, the 2nd build "after signing" needs to pass in --build-reproducible-date with the same value from the 1st build, this will apply to Mac as well.
@andrew-m-leonard so the fix should be in temurin-build script not in reproducible tooling?
@andrew-m-leonard so the fix should be in temurin-build script not in reproducible tooling?
Yes, I will do a separate PR to fix the value for Windows & Mac. It's good this work is catching problems with our SBOM :-)
Fix for Windows SBOM BuildTimestamp: https://github.com/adoptium/temurin-build/pull/3846
Latest diff.txt
Cleaning any Temurin build-scripts release file BUILD_INFO from /cygdrive/c/comp-jdk-build/compare/tar_jdk
Successfully removed all SystemModules jdk.jpackage hash differences from /cygdrive/c/comp-jdk-build/compare/tar_jdk
Normalizing ModuleAttributes order in module-info.class, converting to javap
Number of files: 105221
Comparing /cygdrive/c/comp-jdk-build/compare/src_jdk with /cygdrive/c/comp-jdk-build/compare/tar_jdk ... output to file: reprotest.diff
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/bin/server/jvm.dll and /cygdrive/c/comp-jdk-build/compare/tar_jdk/bin/server/jvm.dll differ
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/jmods/expanded_java.base.jmod/lib/server/jvm.dll and /cygdrive/c/comp-jdk-build/compare/tar_jdk/jmods/expanded_java.base.jmod/lib/server/jvm.dll differ
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$1.class and /cygdrive/c/comp-jdk-build/compare/tar_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$1.class differ
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$2.class and /cygdrive/c/comp-jdk-build/compare/tar_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$2.class differ
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$3.class and /cygdrive/c/comp-jdk-build/compare/tar_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$3.class differ
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$4.class and /cygdrive/c/comp-jdk-build/compare/tar_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$4.class differ
Files /cygdrive/c/comp-jdk-build/compare/src_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$5.class and /cygdrive/c/comp-jdk-build/compare/tar_jdk/lib/modules_extracted/java.base/jdk/internal/module/SystemModules$5.class differ
Number of differences: 7
ReproduciblePercent = 99.99 %
@andrew-m-leonard
Windows reproducible comparison tests failed when rebuild
https://ci.adoptium.net/job/Test_openjdk22_hs_dev.system_x86-64_windows_testList_2/2/console
@andrew-m-leonard