search

adoptium / temurin-build

Eclipse Temurin™ build scripts - common across all releases/versions
Apache License 2.0
1.02k stars 247 forks source link

Figure out what Windows builds are doing with the tag parameter #690

Open sxa opened 5 years ago

sxa commented 5 years ago

jNeed to understand this in order to attempt to fix https://github.com/AdoptOpenJDK/openjdk-website/issues/338 / https://github.com/AdoptOpenJDK/openjdk-build/issues/678 - I'm creating this issue mostly to track what I'm doing ;-) I could possibly make use of ADDITIONAL_FILE_NAME_TAG but that likely wouldn't fix the tag on the main web site.

Build 42 with tag jdk8u192-bXX_openj9_0.11.0_DONOTUSE) failed with:

dllmain.c
copyright.c
Microsoft (R) Windows (R) Resource Compiler Version 6.1.7600.16385

Copyright (C) Microsoft Corporation.  All rights reserved.

j9thr.rc(8) : error RC2104 : undefined keyword or key name: XX_openj9_0

make[4]: *** [../omr/omrmakefiles/rules.win.mk:193: j9thr.res] Error 1
make[3]: *** [makefile:40: ../j9thr29.dll] Error 2
make[2]: *** [makefile:209: j9thr] Error 2
make[1]: *** [/cygdrive/c/cygwin64/tmp/tmp.i1RfwCSGXZ/workspace/build/src/closed/OpenJ9.gmk:416: build-j9] Error 2
make: *** [/tmp/tmp.i1RfwCSGXZ/workspace/build/src/closed/make/Main.gmk:36: j9vm-build] Error 2

Build 43 with tag jdk8u192-bXX-DONOTUSE-SXA failed with:

aborted dllmain.c
copyright.c
Microsoft (R) Windows (R) Resource Compiler Version 6.1.7600.16385

Copyright (C) Microsoft Corporation.  All rights reserved.

j9thr.rc(8) : error RC2104 : undefined keyword or key name: XX

make[4]: *** [../omr/omrmakefiles/rules.win.mk:193: j9thr.res] Error 1
make[3]: *** [makefile:40: ../j9thr29.dll] Error 2
make[2]: *** [makefile:209: j9thr] Error 2
make[1]: *** [/cygdrive/c/cygwin64/tmp/tmp.Y4F7pg1Lkb/workspace/build/src/closed/OpenJ9.gmk:416: build-j9] Error 2

Build 44 was ok with tag jdk8u192-b99-DONOTUSE-SXA Build 45 failed with tag jdk8u192-b99_openj9_0.11.0-SXA-DONOTUSE

karianna commented 5 years ago

I'd ping @johnoliver to see where that gets set

sxa commented 5 years ago

Based on investigations in #725 on the https://ci.adoptopenjdk.net/view/work%20in%20progress/job/SXA-jdk8_j9_win64_build job the failure there occurs of there is an _ character in the TAG field. The filename can be overridden using the ADDITIONAL_FILENAME_TAG option on the individual jobs, but that can't be set from the top level jobs at present.

sxa commented 5 years ago

We could either:

  1. Identify and fix what's broken in the Windows build with the underscores in the tag (Windows resource/rc issue?) (NOTE: The current failures on Win64 are NOT the same as the RC2104 ones mentioned at the top of this item)
  2. Allow the ADDITIONAL_FILENAME_TAG to be passed through from the top level build jobs.

@johnoliver Any ideas on this one?

sxa commented 5 years ago

https://github.com/AdoptOpenJDK/openjdk-build/pull/732 has been submitted in order to implement option 2 from the previous comment. Will keep this open since I want to understand why this is gone wrong in such an odd way as shown by the various tests in https://github.com/AdoptOpenJDK/openjdk-build/issues/725