Closed adamfarley closed 7 months ago
Actions from previous retrospectives:
Topics rolled-over from last retrospective:
Corrected the release pipeline generator link in RELEASING.md in the build repo from https://ci.adoptium.net/job/build-scripts/job/utils/job/release-build-pipeline-generator/ to https://ci.adoptium.net/job/build-scripts/job/utils/job/release-pipeline-generator/
Update release checklist template to remove arm32 from jdk21 table
The release checklist may be out of date in regards to which builds to disable during release week. Currently the checklist suggests disabling standard and evaluation builds, where as historically we disable nightly testing only. Discuss what is most suitable
Recommend that we recreate this PR https://github.com/openjdk/jdk/pull/14942 to deal with issues with jtreg tests seen in AQAvit testing (see https://github.com/adoptium/aqa-tests/issues/4960#issuecomment-1890821702).
Recommendation to improve Deep History view https://github.com/adoptium/aqa-test-tools/issues/837
Increased number of disconnects seen with Orka machines (see https://github.com/adoptium/aqa-tests/issues/4960#issuecomment-1890964598 which references https://github.com/adoptium/infrastructure/issues/2536 and Slack thread for details).
https://github.com/adoptium/infrastructure/issues/2885#issuecomment-1890709946 - No longer have Windows machines where certain jdk_tools tests can pass, hit a Wix toolset configuration error on all of our current set of Windows machines.
https://github.com/adoptium/aqa-tests/issues/4821#issuecomment-1781250210 - jdk_jdi_jdk8_2 passed, jdk_util_2 needs rerunning on odroid - both odroids are offline
[SXA: Ref: https://github.com/adoptium/infrastructure/issues/3043]
Double check if tap files of the rerun test builds are collected or archived to upstream pipeline jobs.
https://adoptium.slack.com/archives/CLCFNV2JG/p1705426218260209
Release trigger scripts will add an extra _adopt suffix to tags even if there already is one https://github.com/adoptium/mirror-scripts/blob/2079f4b2359de21a2ab0d4443664f31c3593b201/triggerReleasePipeline.sh#L67
Expected release tag: jdk8u402
Latest GA tag: jdk8u402-b05-dryrun-ga_adopt
jdk8u402-b05-dryrun-ga_adopt commit SHA: 1736327cb528b638d21e9fac3b63d321efb9d12e
Latest build tag pointing to 1736327cb528b638d21e9fac3b63d321efb9d12e: jdk8u402-b05_adopt
We will proceed with jdk8u402-b05-dryrun-ga_adopt to trigger build
No jdk8u402-b05_adopt_adopt tag found yet, will sleep 10 minutes and check again
No jdk8u402-b05_adopt_adopt tag found yet, will sleep 10 minutes and check again
No jdk8u402-b05_adopt_adopt tag found yet, will sleep 10 minutes and check again
No jdk8u402-b05_adopt_adopt tag found yet, will sleep 10 minutes and check again
No jdk8u402-b05_adopt_adopt tag found yet, will sleep 10 minutes and check again
This is caused by an _adopt tag being at the top of https://github.com/adoptium/jdk8u/tags (at this moment jdk8u402-b05-dryrun-ga_adopt is at the top). Can be fixed by either checking if _adopt is already in the retrieved tag, or by having a fixed order of what appears in https://github.com/adoptium/jdk8u/tags
Update status template to remove 32bit platforms for jdk21 https://github.com/adoptium/temurin/pull/18
TRSS seems to have slowed or stalled receiving and reporting test results, not sure why, whether its the Jenkins server at capacity when queried, or something on the TRSS server. Needs investigation. https://github.com/adoptium/infrastructure/issues/3354
The release publish job seems to take the release name as input. Accidents can happen if the release name doesn't match the common pattern. E.g. JDK-11.0.22+7
vs jdk-11.0.22+7
(upper vs. lower case). Consider adding .toLowerCase()
on the input string. Further refinements would be to configure the name ahead of time and make it a drop down or something.
release tool unexpected operator error in console, though job shows successful and uploaded artifacts successfully
Linux on x64: OK!
Linux on aarch64: OK!
Linux on ppc64le: Not published:
Linux on s390x: Not published:
Linux on arm: Not published:
AIX on ppc64: Not published:
../sbin/releaseCheck.sh: 62: [: x64: unexpected operator
../sbin/releaseCheck.sh: 62: [: aarch64: unexpected operator
Windows on x64: OK!
Windows on x86-32: Not published
MacOS on x64: Not Published:
MacOS on aarch64: OK!
Source images: Not complete:
[EDIT: SXA 22/Jan: Raised at https://github.com/adoptium/github-release-scripts/issues/145 after I spotted it today]
Tests running on aarch64 Linux nodes are painfully slow and hitting 10hr time limit, so aborting and need relaunching https://github.com/adoptium/aqa-tests/issues/4983#issuecomment-1896286171 (not seen during dry run)
Down to a single node online for AQAvit triage
Similar issues for arm_linux machines and x64 alpine-linux machines mid-way through the release activities
4 jdk21 windows testcases can not pass on ci.adoptium.net Jenkins machines, but can on temurin-compliance Jenkins machine (https://github.com/adoptium/aqa-tests/issues/4983#issuecomment-1896504690)
1 minute timeout waiting for an Orka node is not long enough:
15:18:59 Could not find any nodes with 'ci.role.test&&hw.arch.x86&&(sw.os.osx||sw.os.mac)' label
[Pipeline] timeout
15:18:59 Timeout set to expire in 1 min 0 sec
[Pipeline] {
[Pipeline] node
15:19:14 Still waiting to schedule task
15:19:14 All nodes of label ‘[ci.role.test&&hw.arch.x86&&(sw.os.osx||sw.os.mac)](https://ci.adoptium.net/label/ci.role.test&&hw.arch.x86&&(sw.os.osx%7C%7Csw.os.mac)/)’ are offline
15:19:59 Cancelling nested steps due to timeout
Ref: https://github.com/adoptium/ci-jenkins-pipelines/issues/900
Ignore this - as Severin has pointed out to me it's a dup of an earlier comment ~~Release check script appears to have a bug, but I was superficially unable to repliate this on my local machine. https://github.com/adoptium/github-release-scripts/issues/145~~
AIX on ppc64: Not published:
../sbin/releaseCheck.sh: 62: [: x64: unexpected operator
../sbin/releaseCheck.sh: 62: [: aarch64: unexpected operator
Windows on x64: OK!
Release check script appears to have a bug, but I was superficially unable to repliate this on my local machine. adoptium/github-release-scripts#145
AIX on ppc64: Not published: ../sbin/releaseCheck.sh: 62: [: x64: unexpected operator ../sbin/releaseCheck.sh: 62: [: aarch64: unexpected operator Windows on x64: OK!
Same as https://github.com/adoptium/temurin/issues/13#issuecomment-1900826057 ?
https://ci.adoptium.net/job/openjdk_build_docker_multiarch/ running on test-sxa-armv7l-ubuntu2004-odroid-2 and making it unavailable, which is the only online machine arm_linux machine where certain openjdk tests are known to pass (the other static docker nodes are not configured to allow for a green run of sanity.openjdk and extended.openjdk test targets).
There should be 'less pressure' on the -odroid machines once the issues running in the infra static docker nodes are addressed, alternatively, just as we disable testing during release, should we be disabling or reducing the frequency of this docker_multiarch job during release.
release tool: jdk8 x32 windows, I missed the .msi files in this job
When I went to correct the mistake by uploading the 2 missing msi files in this job (and others varyiing the regex), hit this error:
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 bash ./sbin/Release.sh
Processing archive file: OpenJDK8U-jdk_x86-32_windows_hotspot_8u402b06.msi
sed: can't read OpenJDK8U-jdk_x86-32_windows_hotspot_8u402b06.msi.sha256.txt: No such file or directory
Build step 'Execute shell' marked build as failure
Also noting that the verifying Checks when uploading are helpful (indicated 21/23 files were uploaded), but would also be helpful to see this in a Dry run, as it would then help avert more problems.
Will be good to move to our more user-friendly wrapper job (that is now ready to deploy) practicing using it before next release period.
https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the jdk-
prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet.
*** PERFORMING RELEASE CHECK TO SEE IF THERE ARE ANY UNEXPECTED PROBLEMS ***
Grabbing information from https://github.com/adoptium/temurin21-binaries/releases/tag/21.0.2+13
FILTER IS: 21.0.2%2B13
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
100 12464 0 12464 0 0 6000 0 --:--:-- 0:00:02 --:--:-- 6000
100 10.1M 0 10.1M 0 0 4756k 0 --:--:-- 0:00:02 --:--:-- 4756k
Linux on x64: OK!
Linux on aarch64: OK!
Linux on ppc64le: OK!
Linux on s390x: OK!
Linux on arm: Not published:
AIX on ppc64: OK!
Alpine on x64: OK!
Alpine on aarch64: OK!
Windows on x64: OK!
MacOS on x64: OK!
MacOS on aarch64: OK!
Source images: OK!
https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8104/console reports an error when publishing jdk11 release notes
release script verification appears to run a check against Mac aarch64 during this run
MacOS on aarch64: INCOMPLETE: 62/31 (Expect jre, jdk, pkg-jre, pkg-jdk, testimage (Not JDK8), debugimage, static-libs (Not JD8) in base, json, sha256, sig)
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-sbom_aarch64_mac_hotspot_11.0.22_7-metadata.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-sbom_aarch64_mac_hotspot_11.0.22_7.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-sbom_aarch64_mac_hotspot_11.0.22_7.json.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7.1/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-debugimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.pkg.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jdk_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.pkg.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-jre_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-sbom_aarch64_mac_hotspot_11.0.22_7-metadata.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-sbom_aarch64_mac_hotspot_11.0.22_7.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-sbom_aarch64_mac_hotspot_11.0.22_7.json.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-static-libs_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.json
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sha256.txt
https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.22%2B7/OpenJDK11U-testimage_aarch64_mac_hotspot_11.0.22_7.tar.gz.sig
Source images: Not complete:
Not seen when publishing release notes for JDK8, JDK17 and JDK21
https://github.com/adoptium/temurin/issues/13#issuecomment-1908829962
aarch64_mac release jdk-11.0.22+7.1 and jdk-11jdk-11.0.22+7.
Uploading OpenJDK11U-jdk-release-notes_11.0.22_7.json is using tag jdk-11.0.22+7, and releaseCheck.sh is checking doubled aarch64_mac files. If it's uploading release notes only might just skip check process.
@smlambert @sophia-guo My gut feel from the output is that this is likely another symptom of my comment above where it's finding artifacts that are in a tag which is superset of others - in this case I would guess that it's picking up and counting all artefacts in releases that are in jdk-11.0.22+7.1 as well as jdk-11.0.22+7 so finding twice as many.
e.g. in my comment a parameter to the check script of 20.0.2+13
counted artifacts in jdk-20.0.2+13
and I think in your example jdk-11.0.22+7
is probably additionally counting things in jdk-11.0.22+7.1
(Both have mac/aarch64 artifacts in them so it finds twice as many as expected so declares an error condition)
If it's uploading release notes only might just skip check process.
I think it would be better to add the release notes into the check in the same way as we do for the source archive (Noting also that Shelley's log above shows Source images: Not complete:
which we should probably fix)
Night tests are disabled during releases. However if Pr in ci-jenkins-pipeline is merged during the releases the tests will be re-enabled again as jobs are regenerated.
Shelley action: Go through Post-release actions from AQAvit triage issues and create issues for them:
JDK21:
JDK17:
JDK11:
JDK8:
Retrospective actions summary
Adam:
Shelley:
Suggest that the banner gets taken down when the blog post is published, since that is an appropriate time to mark the end of the release. (noting our banner is still up, and we are completed the main aspects of the release at this time).
Summary
A retrospective for all efforts surrounding the titular releases.
All community members are welcome to contribute to the agenda via comments below.
This will be a virtual meeting after the release, with at least a week of notice in the #release Slack channel.
On the day of the meeting we'll review the agenda and add a list of actions at the end.
Invited: Everyone.
Time, Date, and URL
Time: 2pm GMT, 9am EST Date: Monday, 29th of January URL: https://eclipse.zoom.us/j/85862065826?pwd=yXE1cYzqn2MnHv0BSq36jaTlAxqGxq.1
Details
Retrospective Owner Tasks (in order):