search

adoptoposs / mjml_nif

Elixir NIF bindings for the MJML Rust implementation (mrml)
https://hexdocs.pm/mjml
MIT License
122 stars 17 forks source link

Forcing rustler build using config doesn't work #151

Closed Munksgaard closed 1 month ago

Munksgaard commented 2 months ago

I'm building my elixir projects as a nix flake, which means that I cannot rely on rustler_precompiled. As suggested in the documentation I tried disabling ruster_precompiled by putting the following in my config.exs (and adding rustler to my deps):

config :rustler_precompiled, :force_build, mjml: true

However, it seems like the explicit setting of force_build in native.ex overrides this option.

paulgoetze commented 1 month ago

Hey @Munksgaard, thanks for creating this issue. I'll have a look!

paulgoetze commented 1 month ago

It seems to be a special case problem with the config priority in rustler_precompiled.

:hourglass_flowing_sand: Waiting for more info about this in https://github.com/philss/rustler_precompiled/issues/80 …

paulgoetze commented 1 month ago

@Munksgaard A new version (v4.0.0) is published which fixes the issue with the config. (Re the major version Bump: there should be no breaking changes, it just uses mrml v4.0+ and we sync with that.)

Munksgaard commented 1 month ago

Amazing, thank you :heart: