search

adoptware / pinball

Emilia Pinball : A Libre pinball simulator for GNU Linux
https://purl.org/rzr/pinball
GNU General Public License v2.0
31 stars 15 forks source link

Build tables separately #4

Open rzr opened 5 years ago

rzr commented 5 years ago

It would be good to build tables outside sources, using pinconfig ... and maintain them in separate repo

zezinho42 commented 4 years ago

Well, as a player, I don't mind. But as an hacker, yes it could be good to be able to test table changes without recompiling.

rzr commented 4 years ago

the reason is that tables can evolve separately and could be composed of unfree contents

rzr commented 4 years ago

Hi dear pinball contributors (@zezinho42, @sergiomb2, @orbea ...)

I have news to share I managed to build the gnu table independently, I am considering to create a new repo that can be used as template can you suggest a better name than "pinball-table-gnu" ?

Beta tests are welcome...

Legacy tables might stay inside pinball main source, but others might evolve on their own repo.

Please help by listing and contacting all pinball data contributors.

Regards and happy EoY

sergiomb2 commented 4 years ago

you have all table Licenses here: https://github.com/sergiomb2/pinball/blob/master/License.txt

2) gnu table licenses are (GFDL or Free Art or CC-BY-SA) and GPLv3 and
CC-BY-SA (data/gnu/README)
3) hurd table license is GPLv2+ (data/hurd/README.txt)
4) professor table license is GPLv2+ (data/professor2/README.txt)
sergiomb2 commented 4 years ago

Beta tests are welcome...

I'd like test it , where is the code ? please

Thanks

rzr commented 4 years ago

Merry #GMass : a #GNU #pinball table to play with #EmiliaPinball on #GnuLinux (more to come)

https://github.com/rzr/pinball-table-gnu#

rzr commented 4 years ago

Any feedback ? I also plan to relocate code of hurd table ouside main repo and then eventually make a new release, any important patch that should go to master ?

zezinho42 commented 4 years ago

Any feedback ?

Sorry, no time for test here for now...

rzr commented 4 years ago

The hurd table is no more in master branch does any one want to maintain or co-maintain it like the gnu table ?

zezinho42 commented 4 years ago

The hurd table is no more in master branch does any one want to maintain or co-maintain it like the gnu table ?

I think I can do that...

rzr commented 4 years ago

Thanks @zezinho42 have you checked

https://github.com/rzr/pinball-table-gnu#

let me push similar "work in progress" I have done on hurd table

zezinho42 commented 4 years ago

Thanks @zezinho42 have you checked Not yet. It would be handy to have a README file explaining how to build the tables also.

rzr commented 4 years ago

May also ping @paolo-caroni about this "new" project:

https://github.com/rzr/pinball-table-hurd

I also plan to adopt Debian's pinball package and wish we can also submit those 2 new tables as extra packages.

It would be good to see if I missed any valuable patches.

rzr commented 4 years ago

Relate-to: https://github.com/rzr/pinball-table-gnu/issues/3

rzr commented 4 years ago

Following: https://github.com/rzr/pinball-table-gnu/issues/3

hi @sergiomb2 , thanks for your comment

let me explain again, I don't see any value "to pollute" the engine source code with assets, we have 2 samples tables I think it's enough, tables can evolve in parallels without relying on upstream.

I made those 2 as examples.

Now there is a 3rd one called house , I am the author of it and I didn't distribute it properly, did you distribuate it into fedora? this one is not based on Free contents so it should be mixed along sources, if you did please let me know before cleaning it up, I can rework it too.

Do you know any other tables ?

sergiomb2 commented 4 years ago

No, I just know about gnu, hurd, professor (two versions) and tux [1] .

[1] https://github.com/sergiomb2/pinball/tree/master/data

paolo-caroni commented 4 years ago

If I don't remember wrong there was an horror table modification of tux table for windows... but I have to check on the old computer that is still in my parents house.

rzr commented 3 years ago

yea I was the author of this table , some contents are at:

http://rzr.online.fr/games.htm

What about professor2 one

paolo-caroni commented 3 years ago

Professor 2 is only a graphical improvement of professor, I've never complete the game logic.

rzr commented 3 years ago

may this merged upstream ?

paolo-caroni commented 3 years ago

I've added my last version to sergiomb repo... https://github.com/paolo-caroni/pinball/commit/8d6aea8f2f2f4a644d349b3c3d034e7482630d6d

if you want made same effort of Hurd on Professor2 you are obviously welcome. Also you can improve the game logic if you wish (in that case add your name in copyleft notice too).

sergiomb2 commented 3 years ago

one day I'd like copy backgrounds from professor to professor2 and drop professor .

rzr commented 3 years ago

Extra note at:

https://github.com/sergiomb2/pinball/commit/2b3d82b3689a466a03c9be2ea52da27b59805e74

For redhat related issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1290935#