adorableio / react-native-animated-ellipsis

A simple, customizable animated dots component for use in React Native apps. Ideal for loading screens.
MIT License
80 stars 45 forks source link

add useNativeDriver as prop #12

Open NickLewry opened 4 years ago

NickLewry commented 4 years ago

Apologies I've just realised theres another PR open that addresses this, although I believe my solution is more flexible so I'll keep it open and it's up to you.

LucasHimelfarb commented 4 years ago

please, i need this change...

NickLewry commented 4 years ago

@benadamstyles @mcavaliere @BaseCase could you take a look when you get a chance please?

NickLewry commented 4 years ago

can you merge @mcavaliere @BaseCase ? thanks

NickLewry commented 4 years ago

@benadamstyles can we merge this please?

NickLewry commented 4 years ago

@benadamstyles @mcavaliere @BaseCase one last try

benadamstyles commented 4 years ago

Sorry I don't have write access, I can review but I can't merge!

RolandasSTRG commented 4 years ago

@BaseCase could you please merge the request?

xlanor commented 4 years ago

I forked this and published it to npm, since it's affecting our devs workflows at work. Please let me know if the PR is merged so that I can remove my fork.

johnbonds commented 3 years ago

+1 on merging this. Pretty please with sugar on top?

developmentByJuned commented 3 years ago

is it merged ?

EfeAgare commented 3 years ago

Still waiting for this PR to be merge

developmentByJuned commented 3 years ago

I did the workaround. But if the pr is merged it will save some hassle

On Tue, 6 Jul, 2021, 1:09 pm Agare Efe Knowledge, @.***> wrote:

Still waiting for this PR to be merge

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adorableio/react-native-animated-ellipsis/pull/12#issuecomment-874534431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT66CY55CWV7F2D4V73OD3LTWKXKJANCNFSM4N3PSJBQ .

Thanhal-P-A commented 1 year ago

https://www.npmjs.com/package/rn-animated-ellipsis