search

adorade / gulp-stylelint-esm

Gulp plugin for running Stylelint results through various reporters.
MIT License
6 stars 1 forks source link

Formatters are not called correctly #20

Closed kksandr7 closed 5 months ago

kksandr7 commented 5 months ago

Hello. At the moment I am not getting any error report in the output.

The problem is that the second argument returnValue is required for the Formatter call and the call fails when trying to get ruleMetadata.

I suggest passing the entire LinterResult object to the reporter instead of the LinterResult.results grouping. This will solve the problem of passing the results to the formatter.

adorade commented 5 months ago

Hi @kksandr7 thank you for reporting this issue. Unfortunately, PR #21 didn't pass the test after I approved the review. Can you tell me which version of stylelint and gulp you use? I want to reproduce what you do so I can figure out what's going on.

kksandr7 commented 5 months ago

My versions: gulp@5.0.0 stylelint@16.6.1

It seems that the current tests that check the output are not compatible with the fix and will also need to be updated, since now the formatter() call will only include information about 1 file.

kksandr7 commented 5 months ago

I fixed the test. I removed the check that a group of files was received, and in the results I rely on the file name to check the expected results for each file separately.

adorade commented 5 months ago

I will check when I will have free time available. Keep in touch!

adorade commented 5 months ago

I have tested the changes made. Regrettably, they are not functioning with gulp v5. I will conduct further investigations, as there may be a compatibility issue with gulp v5. It is essential for the plugin to be compatible with both gulp versions 4 and 5. Without any modifications, the plugin is compatible with gulp v4 and any version of stylelint greater than 16.

kksandr7 commented 5 months ago

But the tests have been passed, what exactly are your problems?

I also work with gulp v5 and stylelint v16 and this fix allows me to see problems in the console output, otherwise it is silent.

Also, these changes are related only to stylelint, it is unlikely that the gulp version has any influence on this. Have you looked at the signature of the method in which the problem occurred? I left a link to it in the description and explained what the problem was.

adorade commented 5 months ago

Test passed with gulp v4, but not gulp v5.

Plugin Functionality › should emit an error on streamed file

kksandr7 commented 5 months ago

I missed this point, but I can say that the tests do not pass for gulp v5 even without my changes, and to fix the tests for gulp v5 it is worth opening a separate issue.

adorade commented 5 months ago

I tried with the changes made by you and gulp v5 on a project of mine and it works. Something misses me on the test and I don't realize what. Interesting!