adorobis / hacomfoairmqtt

Home Assistant integration for ComfoAir 350 device via serial communication and MQTT
MIT License
37 stars 16 forks source link

Fix RPM calculation #13

Closed mweimerskirch closed 3 years ago

mweimerskirch commented 3 years ago

According to the reverse engineered protocol, you have to divide 1875000 by the value to get the RPM. At least that's how I understood it.

mweimerskirch commented 3 years ago

@TimWeyand Maybe you can review this, as you added the RPM calculation recently. Did I maybe misunderstand the documentation?

TimWeyand commented 3 years ago

I haven't seen the ** next to 0x00 0x0B documentation, nice catch!

My Readings right now: 50%: 1.110 RPM (?) - your calculations: 1875000 / 1.110 = 1689 RPM (?) 100%: 730 RPM (?) - your calculations: 1875000 / 730 = 2568 RPM (?)

Makes more sense! Thank you.

adorobis commented 3 years ago

Great fix! Now also my readings make some sense, I didn't get this neither when tried to read the RPM data...