adorobis / hacomfoairmqtt

Home Assistant integration for ComfoAir 350 device via serial communication and MQTT
MIT License
37 stars 16 forks source link

Feature request: Add support for RS485 communication to WHR950 #17

Closed mogwai2 closed 3 years ago

mogwai2 commented 3 years ago

Would you consider adding support for the WHR950 based on the RS485 communication protocol: https://matsab.de/de/heimautomatisierung/comfoair

Attached a modified version of your script that I made and tested.

What is working:

Not yet working:

My modified version of the script. I see that quite some changes have been made in the meantime, I could merge my changes in the new version and test if that would help you... whr950.zip

adorobis commented 3 years ago

My modified version of the script. I see that quite some changes have been made in the meantime, I could merge my changes in the new version and test if that would help you...

Yes, this would be the best approach - create your fork and implement the changes there, keep it in sync with the main branch as it is still quite in development. A few more points to be considered:

  1. It would require a configuration parameter (now in config.ini file) to define which version it is using: RS232 or RS485
  2. With limited number of functions, especially the missing ones for controling the unit, it would require some additional parameters to define which functions are enabled.
  3. You would need to figure out the checksum calculation method and return codes so it is in line with the way the program works now.
mogwai2 commented 3 years ago

I managed to add basic RS485 support without major changes to the main code. I have no experience with github, but think I managed to create a pull request with my code updates. Please check it out.

adorobis commented 3 years ago

Basic support added in PR https://github.com/adorobis/hacomfoairmqtt/pull/18 Many thanks @mogwai2 !