adorobis / hacomfoairmqtt

Home Assistant integration for ComfoAir 350 device via serial communication and MQTT
MIT License
37 stars 16 forks source link

Fix bypass sensors autodiscovery #22

Closed PimDoos closed 3 years ago

PimDoos commented 3 years ago

Autodiscovery for Bypass Valve and Bypass Mode were not discovered properly. Changed them from binary_sensor to sensor to make sure they get discovered properly. image

adorobis commented 3 years ago

actually those sensors should remain as binary_sensor as they are later on used directly in the lovelace card to indicate if it is already in Summer mode and if the bypass is on or off. There were some other changes needed to make them actually work as expected. Two more sensors can be added to auto discovery to take MQTT topics comfoair/bypassmode and comfoair/bypassstatus - they are being published at the moment but do not have respective autodiscovery sections.

adorobis commented 3 years ago

I've also added the sensors for bypass mode and bypass status to autodiscovery so both binary_sensor and sensor are available in HA now.

PimDoos commented 3 years ago

Thanks!