search

adorobis / hacomfoairmqtt

Home Assistant integration for ComfoAir 350 device via serial communication and MQTT
MIT License
37 stars 16 forks source link

Deploy project as Docker container #46

Closed jschanz closed 1 year ago

jschanz commented 1 year ago

Hi ... I've extended the project to run the Python script in a Docker container, because I neither use HAOS nor a FreeBSD based operating system. Before creating a Debian installation, I assume a Docker container is much easier to handle for most people. Maybe someone has the knowledge to add this in the AddOn-Store.

Please have a look at the code and merge it to your repository if you appreciate it. Thanks for your great work!

adorobis commented 1 year ago

Great idea, many thanks! Could you just enlighten me on the SOCAT concept? Why would you expose the serial port over TCP/IP? Edit: I got it now - well explained in the readme file :) Need to test it now in my docker environment.

revog commented 1 year ago

FYI I already built another Docker container with customizable options through ENV vars a while ago: https://github.com/revog/hacomfoairmqtt

Thanks for your great code base!

EDIT: I've just seen that your written Dockercompose file is quite equal - so no need for me maintaining my own. Great!!

adorobis commented 1 year ago

Btw, @jschanz - would you be able to move the docker deployment part from readme to the Wiki? I think it would make things more structured and aligned :)

jschanz commented 1 year ago

I'm not sure if I can edit the wiki pages, because they are not part of the repository. Maybe it's better to create another markdown file like INSTALL.md in docs for the installation.

adorobis commented 1 year ago

I've invited you to repo collaborators, I believe this should be enough to edit the wiki pages :)

adorobis commented 1 year ago

Anyway, don't worry, I've just done that as the formatting of wiki pages is exactly the same as readme files.

jschanz commented 1 year ago

I've invited you to repo collaborators, I believe this should be enough to edit the wiki pages :)

Sorry .. I was very busy the last days. If you need further assistance with the wiki pages, you may resend me the inviation, because it was expired a few days ago.