Bugfix: add "off" as a valid fan mode

adorobis / hacomfoairmqtt

Home Assistant integration for ComfoAir 350 device via serial communication and MQTT

MIT License

37 stars 16 forks source link

Bugfix: add "off" as a valid fan mode #9

Closed mweimerskirch closed 3 years ago

mweimerskirch commented 3 years ago

The "off" option was already supported, but it was missing from the UI in HomeAssistant.

adorobis commented 3 years ago

I have one question here. What does the "auto" mode do for fan? It is not handled in the on_message function and as such the comfo air does not have an "auto" mode (at least not mine 350 model)

mweimerskirch commented 3 years ago

You're right, I didn't notice that yet. It's neither supported in the on_message method, nor is it used in get_ventilation_status. The only values used for "comfoair/ha_climate_mode/fan" are "off", "low", "medium" and "high". Should be safe to remove.

mweimerskirch commented 3 years ago

I added an issue as a reminder to add proper support to enable auto mode: #10

adorobis commented 3 years ago

Excellent! All good now :)