adorsys / datasafe

Secure, Encrypted and Versioned Data Storage Library
https://adorsys.github.io/datasafe/
GNU Affero General Public License v3.0
51 stars 21 forks source link

185 more restrictive api for string arguments #327

Closed forkimenjeckayang closed 1 month ago

forkimenjeckayang commented 1 month ago
max402 commented 1 month ago

It looks like original issue was fixed long time ago. URI was replaced with url-safe Uri wrapper class. The TODO in BasePrivateResource can be removed.

forkimenjeckayang commented 1 month ago

Noted Sir @max402 , i noticed too that's why there was little or nothing to do with the rest apis in datasafe-rest-impl. And by removing the TODO in BasePrivateResource you mean everything from line 30 and below or just the 1 arg constructor ?

max402 commented 1 month ago

@forkimenjeckayang No, I mean remove only the TODO comment line

forkimenjeckayang commented 1 month ago

Oh okay , just from doing that.

max402 commented 1 month ago

@forkimenjeckayang please rebase you branch on top of current develop

forkimenjeckayang commented 1 month ago

OK @max402 , i have done that

forkimenjeckayang commented 1 month ago

Hello @max402 Should i go ahead and merge then close or you will do it