Closed forkimenjeckayang closed 1 month ago
It looks like original issue was fixed long time ago. URI was replaced with url-safe Uri wrapper class. The TODO in BasePrivateResource can be removed.
Noted Sir @max402 , i noticed too that's why there was little or nothing to do with the rest apis in datasafe-rest-impl. And by removing the TODO in BasePrivateResource you mean everything from line 30 and below or just the 1 arg constructor ?
@forkimenjeckayang No, I mean remove only the TODO comment line
Oh okay , just from doing that.
@forkimenjeckayang please rebase you branch on top of current develop
OK @max402 , i have done that
Hello @max402 Should i go ahead and merge then close or you will do it