search

adorsys / didcomm-mediator-rs

Simple mediator for DIDComm Messaging v2
Apache License 2.0
2 stars 0 forks source link

Iss7 sample pop server #11

Closed francis-pouatcha closed 10 months ago

francis-pouatcha commented 11 months ago

@IngridPuppet I think we will be closing this pull request without merging, right. As the job is redone in the branch iss7-sample-pop-server-bis

IngridPuppet commented 11 months ago

@francis-pouatcha I disagree. I use this branch as my "stable" branch, and consequently as a reference point for your review. I'll periodically merge the work from iss7-sample-server-bis like I did this morning.

francis-pouatcha commented 10 months ago

Do we want to hae the branch merge to main?

IngridPuppet commented 10 months ago

I finally agree to close the pull request without merging. It is better to open another one once I am done, and there is a real intention to merge to main.

IngridPuppet commented 10 months ago

This went quicker than I thought. This pull request is now ready to be reviewed and merged into main.

francis-pouatcha commented 10 months ago

While reviewing, i noticed that you test rely on me generating s keystore manually using the bin/didgen. But this will fail in the ci pipeline.

francis-pouatcha commented 10 months ago

All is fine here, i added the generation step to the ci script