Remove library's R.string.app_name

adorsys / secure-storage-android

Store strings & credentials securely encrypted on your device

Apache License 2.0

367 stars 58 forks source link

Remove library's R.string.app_name #46

Closed DeweyReed closed 5 years ago

DeweyReed commented 5 years ago

The library's R.string.app_name is redundant because it isn't used and the app defines its own app_name anyway. But it has a side effect.

If I use this library in an android library module which doesn't define app_name, when I run the library module's instrumented tests, the library module's APK that is installed on the device will be named Secure Device Storage which is misleading.

luckyhandler commented 5 years ago

Hi Dewey, makes sense. Thanks for your contribution. Just give me a little time for merging the PR.

luckyhandler commented 5 years ago

Hey @DeweyReed Could you change your PR to be merged into develop, please?

DeweyReed commented 5 years ago

@luckyhandler I've changed the target branch to develop but it includes many other commits. Would it be better if I create another PR based on develop branch?

luckyhandler commented 5 years ago

yeah, this would be great @DeweyReed