search

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
132 stars 62 forks source link

Package namespace for spi-api #11

Closed keilw closed 6 years ago

keilw commented 6 years ago

Maybe this also has something to do with Spring and the way it handles different packages and beans, but I'm wondering, why the package namespace in the spi-api module is de.adorsys.aspsp.xs2a.spi.* ?

Isn't this SPI/API a manifestation of the Berlin Group definitions, that should be independent of a particular ASPSP/Bank?

keilw commented 6 years ago

I noticed while the repository is called "xs2a" the Maven groupId for everything is de.adorsys.aspsp, not de.adorsys.xs2a as some may have expected. If that remains unchanged, a package name root like de.adorsys.aspsp also feels consistent at least with the groupId.

jfractalus commented 6 years ago

Thank you for your comments, we will think it over an probably plane it for one of our next sprints

keilw commented 6 years ago

Happy to help, it is somewhat related to #12 although they can each be handled individually (e.g. in different sprints)

jfractalus commented 6 years ago

Yes, sure

keilw commented 6 years ago

actually "spi-api" or any "-" is not a legal character for a package, so it is not an option.