search

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
132 stars 62 forks source link

Consider renaming the spi- modules to xs2a- #12

Closed keilw closed 6 years ago

keilw commented 6 years ago

The architecture documentation states:

Basically the content of spi-api are mainly API Domain objects representing the PSD2 XS2A Interface of Berlin Group or similar. Therefore "SPI" makes not so much sense. Calling it e.g. "xs2a-api" and "xs2a-mock" plus the existing "xs2a-impl" would sound more consistent.

sebrandt commented 6 years ago

Basically the content of spi-api are mainly API Domain objects representing the PSD2 XS2A Interface of Berlin Group or similar. Therefore "SPI" makes not so much sense. Calling it e.g. "xs2a-api" and "xs2a-mock" plus the existing "xs2a-impl" would sound more consistent.

Please don't. The SPI is to allow integration with customer specific banking backends. That is a very different aspect than the exposition of Berlin Group REST services. SPI API model classes now have their own packages and are clearly recognizable through a naming convention (Spi...) While it is to be expected that the structure of SPI-API classes at first resemble a lot those used as internal model for the Berlin Group REST API (no need to "invent" another model), having a clear separation allows decoupling of both aspects (service exposition vs. backend integration).

keilw commented 6 years ago

Ok thanks, than let's close this ticket.