search

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
132 stars 62 forks source link

Why is the groupId "aspsp" and not "xs2a" or similar? #13

Closed keilw closed 5 years ago

keilw commented 6 years ago

The other issues before were answered, so putting the remaining question into a new one.

Why was the groupId de.adorsys.aspsp used for this repository, while others like multibanking or smartanalytics use de.adorsys.multibanking and de.adorsys.smartanalytics?

The keywords for the repository are "xs2a", "xs2a-interface" or "psd2", so why was just a particular actor within the Berlin Group XS2A definition "ASPSP" selected as the groupId instead of "XS2A" or "PSD2"?

maypolikarpova commented 6 years ago

Yes, we know about this problem with naming packages, thank you. We are going to fix this in the next sprints.

keilw commented 6 years ago

@jfractalus @maypolikarpova What is the resolution here? Is the next sprint already over?

keilw commented 6 years ago

@maypolikarpova @jfractalus I trust there may be a solution for this, because a new module (it looks like it uses the same YAML as the one in a separate repository) xs2a-server-api uses de.adorsys.psd2 as package name but inherits the groupId de.adorsys.aspsp from all the others?

maypolikarpova commented 6 years ago

For now all of our team are busy with the massive relocation to 1.2v. We wrote that we will fix that in the next sprints, not in the "next sprint" (which is current). So we will need maybe 1-2 more sprints to be done with issues we have, and than we will resolve this one. Thank you again for making our code better, we did not forget about this issue, just postponed it.

keilw commented 6 years ago

Thanks for the update. I understand, that changing especially a groupId is not so trivial. If e.g. this could be done with or after changes by Berlin Group 1.2 are taken into consideration, that sounds fine to me. It is a little unusual to close the ticket before that change is done, but as long as it's not forgotten, OK.

keilw commented 6 years ago

I trust you're refactoring and resolving some of these things, because after a sync of the upstream codebase now there are 3 groupIds: de.adorsys.aspsp, de.adorsys.multibanking and de.adorsys only (for psd2-validator, which then again has a parent of de.adorsys.aspsp) I'm leaving the Keycloak related modules aside, because they also do not matter for what we do right now (in Redirect mode) but that is a separate item not directly related to PSD2 or XS2A, so it sounds OK.

DG0lden commented 5 years ago

We plan to perform some modules restructuring in the next weeks, it may also affect package renaming. We are about to decide between "de.adorsys.xs2a" and "de.adorsys.psd2" as main-package and maven groupId.

To keep it traceable I reopen the issue.

keilw commented 5 years ago

Thanks, that is good to hear.

DG0lden commented 5 years ago

Main package and GroupId will be "de.adorsys.psd2". Will be step-by-step adjusted in the next two sprints

keilw commented 5 years ago

Thanks for the update.

DG0lden commented 5 years ago

Finally main code base is migrated. Starting release 1.11 main package and artifactID are "de.adorsys.psd2"

keilw commented 5 years ago

Great to see it's complete now. Thanks a lot.