Closed spark404 closed 5 years ago
You are right, I make a review on the spec ("The PSD2 specific attributes shall be included in a QCStatement within the qcStatements extension as specified in clause 3.2.6 of IETF RFC 3739 [6].")
Thanks for the contribution, it will be merged.
Hello Hugo,
could you please swap lines 40-43 of de.adorsys.psd2.validator.common.PSD2QCStatement, so that our quality checks pass: "Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.."
Tests in error: CertificateExtractorUtilTest.testExtractCertDataValidCert:46 » ArrayIndexOutOfBounds
As far as i understand the certificate specs, multiple qcStatements can be present in a certificate. This patch changes the validator behaviour to account for this (and at the same time support the current test certificate)