search

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
134 stars 63 forks source link

Move src/test/config/Insomnia.json to scripts/tests/insomnia or deprecate #17

Closed keilw closed 6 years ago

keilw commented 6 years ago

As Postman test definitions were recently added to scripts/tests/postman the earlier location of similar Insomnia definitions under src/test/config seems redundant and inconsistent. I'd be happy to factor them under a similar folder like scripts/tests/insomnia, unless Postman was preferred as the only REST testing tool, in that case I may also deprecate/remove them.

DG0lden commented 6 years ago

Hi Keil, it is already planned. See branch https://github.com/adorsys/xs2a/tree/dgo_move_insomnia_to_scripts

We internally use only postman and not insomnia, so we'll update only postman right now.

keilw commented 6 years ago

Hi @DG0lden Thanks for the update, then I don't need a PR for this. While importing seemed fine, I faced some issues with newly created Postman defs with what seemed like a bug in Postman, but some of the current clients also use it, so no problem using Postman there.

DG0lden commented 6 years ago

insomnia.json was moved to scripts/tests/insomnia