adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
133 stars 63 forks source link

Is it really a good idea to version the cucumber reports? #25

Closed keilw closed 5 years ago

keilw commented 5 years ago

I have not fully run all Integration Tests locally, but even a quick test run of CucumberIT recreates the cucumber.json file every time. Not sure, if there is a real value of proposing PRs for that file or keeping it in Git at all?

DG0lden commented 5 years ago

Hi Werner, integration tests are put on hold and will be removed completely from the repo in the next days. Regards, Denys

keilw commented 5 years ago

Hi Denys,

Thanks, but is the general idea of using Cucumber with some REST glue (Spring, Restasured, etc.) still valid for other kinds of integration and acceptance tests or did you also spot any flaws and issues with those?

Regards, Werner

DG0lden commented 5 years ago

The main reason is, that we would like to develop our test according to NISP test plans, and we cannot do it open source, since NISP do not publishes its work OS. Regarding Cucumber - the main idea, that BA is able to write tests in Cucumber without developer is not working for us, so we'll do the tests in SPOK framework, that's much more lighter for writing tests.