Updating authorsation status not working like api-doc - Githubissues

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.

https://adorsys.com/en/products/

GNU Affero General Public License v3.0

130 stars 62 forks source link

Updating authorsation status not working like api-doc #41

Closed benmoeARZ closed 5 years ago

benmoeARZ commented 5 years ago

Place where bug appeared

de.adorsys.psd2.consent.web.psu.controller.CmsPsuAisController.updateAuthorisationStatus
de.adorsys.psd2.consent.web.psu.controller.CmsPsuPisController.updateAuthorisationStatus

Current behavior

ScaStatus.valueOf() is used to map incoming String "status", throws IllegalArgumentException when values due to API-Doc are used (lowercase)

Expected behavior

I think ScaStatus.fromValue should be used to satisfy API-Doc

Steps to reproduce

Call PUT /{consent-id}/authorisation/{authorisation-id}/status/finalised
Call PUT /{payment-id}/authorisation/{authorisation-id}/status/finalised

XS2A version(s):

2.0.0

maypolikarpova commented 5 years ago

Thanks, we will have a look at the issue.

Seregy commented 5 years ago

The issues has been fixed in versions 2.4 and 3.2