Logging of RequestId/InternalRequestId via slf4j MDC - Githubissues

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.

https://adorsys.com/en/products/

GNU Affero General Public License v3.0

130 stars 62 forks source link

Logging of RequestId/InternalRequestId via slf4j MDC #59

Closed benmoeARZ closed 4 years ago

benmoeARZ commented 4 years ago

Current behavior

Currently, the request-id and in-request-id are logged explicitly. So when we are logging in custom spi implementation, every logging message must be extended with InR-ID: [{}], X-Request-ID: [{}] or else when we use MDC the information is logged twice for adorsys classes

Expected behavior

When MDC is used, logging format can be changed easyly and every logging message has the information for InR-ID and X-Request-ID. It would also be nice, when the request-ids are propagated to cms/profile serivice so that the Log-messages can be correlated.

Maybe an issue for your backlog?

ViraHavrylenko commented 4 years ago

Hello @benmoeARZ Thanks for the feedback. We'll take it into account.

ViraHavrylenko commented 4 years ago

@benmoeARZ Fixed in xs2a v.5.8