initiation of a "RawPaymentProduct" results in empty payment-information on aspsp/psu api

[benmoeARZ]

Place where bug appeared

• e.g. /psu-api/v1/payment/redirect/{redirect-id}

Current behavior

• Right now the api's for aspsp/psu for getting payment information return no common-payment information when a non-standard-payment-product (none of "sepa-credit-transfers", "instant-sepa-credit-transfers", "target-2-payments", "cross-border-credit-transfers" is requested. E.g. initiation of a pain.001-sepa-credit-transfers with xml content leads to this problem.

Expected behavior

• Should return at least the common-payment information. We Upgraded from 3.11 to 8.0 and in 3.11 we got those information. ( "paymentId", "paymentProduct", "psuIdDatas", "tppInfo", "creationTimestamp","statusChangeTimestamp","paymentType", "transactionStatus","paymentData")

Steps to reproduce

• Initiate a non-standard pament
• request that payment with any payment-getting api-method on aspsp/psu api. (e.g. /psu-api/v1/payment/redirect/{redirect-id} )

SCA approach

• [x] Redirect
• [ ] Embedded
• [ ] Decoupled

XS2A version(s):

• 8.0

Log files or other additional info

de.adorsys.psd2.mapper.CmsCommonPaymentMapperSupportImpl

• currently returns null on each method (mapToCmsSinglePayment, mapToCmsBulkPayment, mapToCmsPeriodicPayment)
• it shouldn't try to parse from json when it is not json
• it should return commonPament when non-standard-payment-product

[kyaex]

Hi!

It seems like you are using wrong dependency, try to replace cms-payment-support-impl with cms-payment-common-impl. Find more information in documentation Configuring CMS Service.adoc https://github.com/adorsys/xs2a/blob/develop/doc/SPI%20Developer%20Guide/Configuring%20CMS%20Service.adoc

[benmoeARZ]

Hi, i know that i can change that dependency, but then i loose all structured information when it's a standard-payment-product or i have to parse the paymentData myself in the client. In any case it's a bug, that you receive no information when it's a non-standard-payment-product. because when you use xs2a-payment-support-impl in xs2a impl there is also a switch see: https://github.com/adorsys/xs2a/blob/6a388fb8f263d5cb11c5e9bf3311e24c8761a720/xs2a-payment-support/xs2a-payment-support-impl/src/main/java/de/adorsys/psd2/xs2a/service/payment/support/PaymentServiceResolverSupport.java#L72

so you can create payments with non-standard-payment-product, but you do not receive any information about that payment when you use cms-payment-support-impl in cms.

[benmoeARZ]

If you decide, that the client needs to parse the paymentData, and you will not support both (structured+common-payment) then the de.adorsys.psd2.consent.api.pis.CmsCommonPayment should also contain the contentType, that's stored in DB (i mean this would be a good idea in any case, but i think for client-parsing it's a precondition)

[ViraHavrylenko]

PaymentMapperResolver was added, please update to xs2a v.8.1