Closed keilw closed 6 years ago
Please remove META-INF from src
Is there still any with .gitignore? Will check, thanks. I could not find a single META-INF folder in the PR. If the global gitignore works, I'll remove the individual ones.
I did update the top level .gitignore accordingly. It created a conflict, but it should be no problem to merge manually.
Please review and let me know, if anything else was needed?
Would be cool to get it fixed soon. The changed files like ReadSinglePayment
show, all other places I spotted call it SinglePayment
, not SinglePayments
.
Please merge develop branch to your branch and fix all conflicts. Thanks
I suspected that other stuff merged from various feature branches may have caused conflicts. I will only fix this mistake (of yours) once more, and please merge it in a more timely manner. If this API is meant to be used by multiple banks for PSD2, it should adhere common naming conventions.
The
spi-api
module had an inconsistent class naming withSpiPeriodicPayment
extendingSpiSinglePayments
. The plural class name seemed wrong here (from a general Java naming convention point) and inconsistent with the periodic payment class.