search

adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
130 stars 62 forks source link

Missing enum value in TransactionStatus? #80

Closed yves-bussard closed 3 years ago

yves-bussard commented 3 years ago

I have not analysed this fully, I must admit. Is it possible that we are missing the value PART in the class TransactionStatus? This class is used in CmsSinglePayment, CmsBuldPayment (as a field).

https://github.com/adorsys/xs2a/blob/6f50a1fe715399a928c512062ec89d57a1e3e548/xs2a-core/src/main/java/de/adorsys/psd2/xs2a/core/pis/TransactionStatus.java#L38

The class de.adorsys.psd2.model.TransactionStatus which is used as a field in the response Object when retrieving the status of a payment in the XS2A Api contains the value PART. The value is also in the swagger file.

HryhoriiHevorkian commented 3 years ago

Hello. We will fix this in the future releases, thank you for comment.

yves-bussard commented 3 years ago

No worries. May I suggest a unit test which verifies that all values are in sync? Therefore changes in XS2A-API will be detected earlier.

yves-bussard commented 3 years ago

I saw that this is fixed with release 9.5