adorsys / xs2a

Open Source NextGenPSD2 XS2A Implementation from adorsys.
https://adorsys.com/en/products/
GNU Affero General Public License v3.0
133 stars 63 forks source link

when a new AIS consent is confirmed with confirmation code the old AIS consent is not being expired. #83

Closed dominikseitz closed 3 years ago

dominikseitz commented 3 years ago

Place where bug appeared

https://github.com/adorsys/xs2a/blob/0777a990c3532d95b5b171e1fd07fa550d800135/xs2a-impl/src/main/java/de/adorsys/psd2/xs2a/service/authorization/ConsentAuthorisationConfirmationService.java#L135

Current behavior

old AIS consents stay in consent management system and are not being expired.

Expected behavior

old AIS consents for the same TPP and PSU should be expired.

If no confirmation code is being used it works fine by calling https://github.com/adorsys/xs2a/blob/78774402f4ae8ecf9fa0c8dd891861274bbf06ff/consent-management/consent-management-lib/src/main/java/de/adorsys/psd2/consent/service/psu/CmsPsuAisServiceInternal.java#L190

Steps to reproduce

SCA approach

XS2A version(s):

Log files or other additional info

dashkok commented 3 years ago

Hello, Thank you for your request. This issue will be fixed with the new release in February. We will let you know as soon as a new version of XS2A will be released.

BR, Daria Lavrenova Opensource team

andriimurashkin commented 3 years ago

Fixed in XS2A for v.8.9 and v.9.8.

@dominikseitz FYI