Closed crimer closed 1 year ago
can you share a test code that shows the error using one of these libraries?
Hi, I found that integrating Popups could be a bit tricky so I've investigated further and found this solution for the CommunityToolki.Maui popup:
[Scaffold(typeof(CommunityToolkit.Maui.Views.Popup))]
partial class Popup
{
protected override void OnAddChild(VisualNode widget, MauiControls.BindableObject childNativeControl)
{
if (childNativeControl is MauiControls.View content)
{
Validate.EnsureNotNull(NativeControl);
NativeControl.Content = content;
}
base.OnAddChild(widget, childNativeControl);
}
protected override void OnRemoveChild(VisualNode widget, MauiControls.BindableObject childNativeControl)
{
Validate.EnsureNotNull(NativeControl);
if (childNativeControl is MauiControls.View content &&
NativeControl.Content == content)
{
NativeControl.Content = null;
}
base.OnRemoveChild(widget, childNativeControl);
}
}
class PopupHost : Component
{
private CommunityToolkit.Maui.Views.Popup? _popup;
private bool _isShown;
private Action<object?>? _onCloseAction;
private readonly Action<CommunityToolkit.Maui.Views.Popup?>? _nativePopupCreateAction;
public PopupHost(Action<CommunityToolkit.Maui.Views.Popup?>? nativePopupCreateAction = null)
{
_nativePopupCreateAction = nativePopupCreateAction;
}
public PopupHost IsShown(bool isShown)
{
_isShown = isShown;
return this;
}
public PopupHost OnClosed(Action<object?> action)
{
_onCloseAction = action;
return this;
}
protected override void OnMounted()
{
InitializePopup();
base.OnMounted();
}
protected override void OnPropsChanged()
{
InitializePopup();
base.OnPropsChanged();
}
void InitializePopup()
{
if (_isShown && MauiControls.Application.Current != null)
{
MauiControls.Application.Current?.Dispatcher.Dispatch(() =>
{
if (ContainerPage == null ||
_popup == null)
{
return;
}
ContainerPage.ShowPopup(_popup);
});
}
}
public override VisualNode Render()
{
var children = Children();
return _isShown ?
new Popup(r =>
{
_popup = r;
_nativePopupCreateAction?.Invoke(r);
})
{
children[0]
}
.OnClosed(OnClosed)
: null!;
}
void OnClosed(object? sender, PopupClosedEventArgs args)
{
_onCloseAction?.Invoke(args.Result);
}
}
and this is how you can use it in your components:
class ShowPopupTestPage : Component<ShowPopupTestPageState>
{
private CommunityToolkit.Maui.Views.Popup? _popup;
public override VisualNode Render()
{
return new ContentPage()
{
new Grid
{
new Button(State.Result == null ? "Show popup" : $"Result: {State.Result.GetValueOrDefault()}")
.HCenter()
.VCenter()
.OnClicked(ShowPopup),
new PopupHost(r => _popup = r)
{
new VStack(spacing: 10)
{
new Label("Hi!"),
new HStack(spacing: 10)
{
new Button("OK", ()=> _popup?.Close(true)),
new Button("Cancel", ()=> _popup?.Close(false)),
}
}
}
.IsShown(State.IsShown)
.OnClosed(result => SetState(s =>
{
s.IsShown = false;
s.Result = (bool?)result;
}))
}
};
}
private void ShowPopup()
{
SetState(s => s.IsShown = true);
}
}
Is it something working for you? I guess that same approach could be adopted for the other library too but let me know if you found issues with that. Thanks
Hi, I tried your example and it worked, thank you very much. Your library is really cool.
I didn't find any example of dialog / popup implementation in your examples. After reading the documentation, I tried to implement compatibility with third-party libraries (Plugin.Maui.Popup, CommunityToolki.Maui), but I failed. Maybe I was doing it wrong. I would like to have an example of how to do it correctly.
Thanks in advance