Closed loki666 closed 7 years ago
Ok.
For surround mode, the problem is that Nuked OPL3 works only in stereo. It would require to mix the channels of the buffer, I wasn't sure if that's what we want performance wise. I can also implement 16bit -> 8bit buffer conversion.
Ah I see. In that case it may be best not to worry about the surround OPL for the time being. Perhaps in future we can investigate something like using the left channel from one instance and the right channel for the other. The CSurroundopl
only supports OPL2 anyway so when the time comes it will probably need some changes too. I'm happy for you to leave out surround OPL support now. But please fix the typo in the error message in that case :-)
Personally I wouldn't worry about the conversion to 8-bit.
Many thanks! Merged in a8d8bc99bc8097aa085a6dad3d46b645d2fa3542
Looking good, just a couple of issues: