adq / redbus

rEdBus: An Edinburgh bus tracker for android!
0 stars 1 forks source link

Tram stops aren't all appearing #1

Open andrewducker opened 9 years ago

andrewducker commented 9 years ago

Some of the tram stops aren't appearing - there should be a pair of them at each location, but at several there's only one stop.

Princes Street West, for instance, only has the stop heading towards York Place.

adq commented 9 years ago

Had a look: what seems to be happening is they've put separate markers for each direction at exactly the same lat/lon... obviously you can only see the topmost.

If you look on mybustracker.co.uk, they have the same problem.. eg look at T50, then the Ingliston P&R stop (next one along from airport). On their site, you can see 36290122, but 36290123 is in fact directly beneath it, I just draw in a different order.

Hmm, will have to think on this one: could simply bump one of the stops away slightly I guess.

andrewducker commented 9 years ago

I notice that the official app brings up both stops together.

Which would actually tie into a feature I've wanted for ages - being able to treat two stops as a single one.

I have two stops near me that both go into town. And two stops near me that both go out of town. If I hit "stops near me" then it shows me departures from all four, which is completely useless and confusing.

What I want to do is attach the two "into town" bookmarks into one bookmark, and the two "out of town" bookmarks into one bookmark.

And once you have that functionality you should be able to automatically group any stops that have the same latitude and longitude as each other into a single stop.

(Of course, I suspect that your data structure doesn't fit into this at all and it would be six month's effort to do this.)

adq commented 9 years ago

Hmm, the bus data itself wouldn't as its very optimised and minimised.

However, the bookmarks aren't stored in there! They're in a sqlite database so adding features to them ain't a problem. I think doing a good GUI for that would actually be the tricky bit rather than the backend storage (as usual :).

For the tram, I think I'll just do what the official app does: show both... I can just query the stops for the current lat/lon and nab 'em all if there is > 1 at that location.

Won't have time to do that tonight as its rather a larger change than the simple scraper screwup I was hoping for.

andrewducker commented 9 years ago

I'll leave it in your capable hands!