search

adr / adr-manager

ADR-Manager
https://adr.github.io/adr-manager/
MIT License
99 stars 22 forks source link

Github-enterprise #159

Open sebastienbrunkyndryl opened 10 months ago

sebastienbrunkyndryl commented 10 months ago

Is-it possible to deploy your solution with an dedicated github-enterprise solution ?

during the login phase, no possibility to choose the target github server.

xJREB commented 9 months ago

I'm not really sure if the APIs differ between the public and the enterprise versions. If they don't for the relatively standard functionality that the ADR Manager uses, then it could be as simple as changing the base endpoint and the rest should work. If they do, it might be more work. We are planning to rework the authentication and the API access anyway to get rid of Pizzly in the middle. That might be a good opportunity to prepare for such changes.

If you want to help, you could try to investigate how the GitHub Enterprise API differs from the public GitHub API, and report the details back here. That would make it much easier to plan and implement such a feature.

xJREB commented 9 months ago

Duplicate of #41

koppor commented 9 months ago

Roadmap:

Since MADR 4.0.0 is almost complete, @sebastienbrunkyndryl do you know about resources helping to upgrade ADR-Manager?

xJREB commented 9 months ago

@koppor, we should also not forget about #156, as it will lead to lots of changes in the code. Right now, Pizzly is very tightly integrated in the code and needs to be replaced in many functions. It should definitely be removed before implementing support for other Git platforms.