search

adr1enbe4udou1n / laravel-boilerplate

Laravel 5.7 Boilerplate based on Bootstrap 4 and Vue Tabler for Backend.
https://laravel-boilerplate.okami101.io
MIT License
259 stars 107 forks source link

"npm run build" command causes a lot of prettier errors #107

Closed pro2s closed 5 years ago

pro2s commented 5 years ago

Hi, I found that when executing a command "npm run build" in the console a lot of prettier errors. For example:

d:\git\bigTest\resources\js\backend\views\Search.vue
5:69  error  Replace `·item.title` with `⏎··········item.title⏎·······`  prettier/prettier
9:20  error  Replace `⏎······Aucun·résultat⏎···` with `·Aucun·résultat`  prettier/prettier
✖ 2 problems (2 errors, 0 warnings)
2 errors and 0 warnings potentially fixable with the `--fix` option.

Is this an issue in my environment or in another?

Windows 10.0.17713 npm v4.2.0 node v6.9.5, node v10.13.0

shirshak55 commented 5 years ago

hmm this project uses eslint. And you are not following prettier rules may be.

Run this command

$ npm run lint
pro2s commented 5 years ago

Run this command $ npm run lint

d:\git\bigTest>npm run lint

> @ lint d:\git\bigTest
> eslint --ext .js,.vue resources/js
adr1enbe4udou1n commented 5 years ago

Ha it's because of BC of the 1.15 prettier version, which have vue js support natively, so conflict with vue-eslint rules... I'll look into it ASAP. But i recommand you to use Yarn instead of npm, so it will take the good 1.14 version of prettier thanks to yarn.lock

adr1enbe4udou1n commented 5 years ago

Fixed, works now with prettier 1.15