adraffy / ens-normalize.js

ENSIP-15 in JS
https://adraffy.github.io/ens-normalize.js/test/resolver.html
MIT License
63 stars 17 forks source link

ens_beautify import issue from @adraffy/ens_normalize #3

Closed wjram2133 closed 1 year ago

wjram2133 commented 1 year ago

ens_beautify cannot not be resolved from @adraffy/ens_normalize, but it will resolve from @adraffy/ens_normalize/src/lib.js

Importing ens_beautify from @adraffy/ens_normalize results in import error therefore to import ens_beautify function the user must point to @adraffy/ens_normalize/src/lib

import { ens_beautify } from "@adraffy/ens_normalize/src/lib"

Testest on: Angular 2.0 v13.4

adraffy commented 1 year ago

Which version of @adraffy/ens-normalize?

Does npm i @adraffy/ens-normalize@latest --save fix the issue? I might not be using semver correctly when I make a breaking change (previous beautify was a boolean option to ens_normalize.)

wjram2133 commented 1 year ago

It would be 1.5.6: "@adraffy/ens-normalize": "^1.5.6", I will update the package now to the latest.

wjram2133 commented 1 year ago

The package has been updated to 1.6.0 but it's encountered the same issue.

adraffy commented 1 year ago

Okay thanks. I will investigate.

adraffy commented 1 year ago

Oh, Angular must use the "browser" import. I forgot to include the extra functions in "only-norm.js".

This will be fixed in the next release.

wjram2133 commented 1 year ago

Thank you.

adraffy commented 1 year ago

This should be fixed in 1.6.1package.json/"browser" points to "index.min.js" instead of "only-norm.js".

wjram2133 commented 1 year ago

Confirmed fixed and working on 1.6.1! Thanks a lot.