Closed makoto closed 1 year ago
Sure, would a separate dist/
file be sufficient? I was thinking of making a build that also polyfills String.normalize()
.
In the meantime, if file size doesn't matter, you could try the reference implementation: https://github.com/adraffy/ens-norm-ref-impl.js
Sure, would a separate
dist/
file be sufficient? I was thinking of making a build that also polyfillsString.normalize()
.
It would be fine as long as I can npm install and import (I am currently doing something like https://github.com/thedumbterminal/bigquery-js-udf-example/blob/main/src/index.js to make it possible to be accessible within Google BigQuery execution environment.
In the meantime, if file size doesn't matter, you could try the reference implementation: https://github.com/adraffy/ens-norm-ref-impl.js
Looks like 7MB size exceeds 1MB file limit
I added an atob implementation. I also now include (by default) a NFC implementation to remove another platform dependency.
I will release this with some other changes tomorrow.
Also, just curious: is there anyway to force that importer to use a different include?
I see dist/index.min.js
is 1.02 MB
, so that won't help in that regard.
I added an atob implementation. I also now include (by default) a NFC implementation to remove another platform dependency.
Great!
Also, just curious: is there anyway to force that importer to use a different include?
What do you mean by this? I am no expert to Google BigQuery but I am guessing 1M is the size limit their platform impose.
I deployed this change in 1.6.3
. Let me know if there are any issues.
What do you mean by this? I am no expert to Google BigQuery but I am guessing 1M is the size limit their platform impose.
I probably had my npm stuff setup incorrectly anyway (I was including too much stuff) but I know applications will use the "browser"
import from the package.json
, instead of following "main"
. But in ref-impl
's case, the minified version was still over the 1MB limit.
Hi. I am trying to use the library within Google BIg Query Javacript User Defined function but failing due to the lack of
atob
function in the environment. I tried to polyfill by myself using method here https://stackoverflow.com/questions/44836246/base64-encoding-in-a-bigquery-user-defined-function but doesn't seem to work. Would it be possible to add something like this?