search

adrai / flowchart.js

Draws simple SVG flow chart diagrams from textual representation of the diagram
http://flowchart.js.org/
MIT License
8.5k stars 1.21k forks source link

fix: Provide low cost means of lines not colliding until they converge #191

Closed robertleeplummerjr closed 4 years ago

robertleeplummerjr commented 4 years ago

Before:

Screen Shot 2019-11-27 at 3 59 31 PM

After:

Screen Shot 2019-11-27 at 4 01 03 PM
adrai commented 4 years ago

You are awesome! I will merge, but can you first look at why the example flowchart is now rendering strange? image npm start and open http://localhost:8000/

And perhaps also test the charts here: https://flowchart.js.org/

btw: can you add here some screenshots of some typical example, how they change?

robertleeplummerjr commented 4 years ago

Yup, resolving.

adrai commented 4 years ago

hehe... no rush... 😉 already late here... will be back tomorrow

robertleeplummerjr commented 4 years ago

fixed

robertleeplummerjr commented 4 years ago

Before: image

After: image

Before: image

After: image

Before: image

After: image

robertleeplummerjr commented 4 years ago

For my purposes, this is what I saw.

Before: image

After: image

robertleeplummerjr commented 4 years ago

The main fix was for connections between "Thing 3" and "Thing 4", I found that the layout engine was resilient enough to know how to layout the "Things" (pun intended) if I severed this connection, but when there were doubled + connections beside each other, it caused the weird overlapping issue. of the green and black. But by adding a feature that was smart enough to count the connections and offset for them, it'd fix this.

FYI.

adrai commented 4 years ago

You're great! This is now included in v1.13.0