search

adrai / flowchart.js

Draws simple SVG flow chart diagrams from textual representation of the diagram
http://flowchart.js.org/
MIT License
8.49k stars 1.21k forks source link

type: add types #214

Closed Mister-Hope closed 3 years ago

adrai commented 3 years ago

Is there some possibility to add some dedicated typescript tests?

Mister-Hope commented 3 years ago

Nope, I have tested on serveral options and usage.

Unless we move the whole project to typescript, adding test has no meanings.

JS do not have types, so I am just writing type test to test my declaration files structure is the structure I wrote.

Mister-Hope commented 3 years ago

I am trying to mirigate to typescript yesterday, but the is a lot of work because the project abuse usage of this, hanging a lot of property. While typescript is requiring all the proerties be declared and typed, so I have to rewrite the whole project.

I am doing the work at https://github.com/Mister-Hope/flowchart.js/tree/ts

I am rebuilding with class and droping ie<= 10 support,

adrai commented 3 years ago

Thank you very much for your contribution. Included in v1.15.0