search

adrai / flowchart.js

Draws simple SVG flow chart diagrams from textual representation of the diagram
http://flowchart.js.org/
MIT License
8.52k stars 1.21k forks source link

Explicit dependencies using require #70

Open sergeyt opened 8 years ago

sergeyt commented 8 years ago

Please consider to refactor the package code in favor of explicit dependencies (instead of //= preprocessor comments) using require to support webpack/browserify wrokflows. Also please explicitly require raphael and add it package.json dependencies. FYI raphael master branch already supports browserify. IMHO this change will be very useful.

sergeyt commented 8 years ago

BTW I've made this PR to make js-sequence-diagrams webpack-friendly.

adrai commented 8 years ago

PR for flowchart.js are welcome too ;-)

sergeyt commented 8 years ago

@adrai I've sent PR #71. What do you think about if I revise build scripts just using webpack without using grunt at all and add npm scripts to package.json?

adrai commented 8 years ago

ok

adrai commented 8 years ago

Do you want to be an official contributor?

sergeyt commented 8 years ago

Thank you, but I'm afraid that I will not have enough time as usual. webpack and eslint helps me to quickly made PR #71, but I don't know this code well now. Maybe later I could help to fix few issues.