search

adrian-budau / easy-motion

Easy Motion for Atom IDE
MIT License
20 stars 4 forks source link

Fix displaying of letters #1

Closed sapphiriq closed 10 years ago

sapphiriq commented 10 years ago

I had to change "overlayer" to "underlayer" to get the plugin to display the letters

adrian-budau commented 10 years ago

Some extra info? It doesn't make any sense. This would just make the letters from easy-motion appear behind the text (this is not intended). The letters should completely replace the original letters while using easy-motion.

If they do not show up at all then could you give me your OS, atom version and some extra plugins you're using?

P.S. I've tried your change and it's not a fix, the whole thing just look weird after.

sapphiriq commented 10 years ago

Oh, I forgot to add z-index to letters. What version of Atom do you use? (mine is 0.103.0). I just don't have overlayer property on @realEditorView. Actually realEditorView has .overlayer class but if I append cover to it, that's what happens: screenshot on 2014-06-16 at 11_28_23

So, appending cover to underlayer and fixing letter-cover's z-index solves the problem and there is no need to calculate offsets.

screen shot 2014-06-16 at 13 04 10

adrian-budau commented 10 years ago

Adding z-indexes still leaves them behind. I tried deactivating everything I installed besides easy-motion and rollback to the original theme and the z-index trick still doesn't work.

I think it's related to one of your plugins (or more likely to your UI Theme). Try going to the original theme and disabling some plugins. At the moment this will break this plugin for everyone else. I also have 0.103.0 and all my plugins (even the default ones) are up to date.

sapphiriq commented 10 years ago

Thanks! I'm sorry for wasting your time. Deleting ~/.atom and reinstalling all the plugins and stuff did the trick :smile: Still don't know what is causing this error (same themes, same plugins and user files).

adrian-budau commented 10 years ago

No problem, I'm glad it's fixed.

Too bad you had the problem in the first place.