adrian-budau / easy-motion

Easy Motion for Atom IDE
MIT License
20 stars 4 forks source link

Improve performance #4

Closed jmacdonald closed 9 years ago

jmacdonald commented 9 years ago

Love this plug-in! That being said, there's a noticeable (2s) delay when first invoking it on a document of just 123 lines. :disappointed:

adrian-budau commented 9 years ago

What delay are you encountering? I've been using it on files with more than 5000 lines and there's no delay. Could you give me some extra information?

jmacdonald commented 9 years ago

Happy to provide some extra info:

Running on OS X Mavericks, Atom 0.129.0, running easy-motion on a Ruby RSpec file. MBP with 16G of RAM, quad-core 2.6Ghz i7.

Don't think hardware is the issue.

adrian-budau commented 9 years ago

My hardware is kind of identical. Can you provide the file if it's not confidential? Or any file you feel like sharing for which the plugin is slow?

jmacdonald commented 9 years ago

So it seems like the plug-in is slow for any file. :disappointed:

Might be a conflicting plug-in? Let me see if I can easily send you a list of my installed plug-ins.

jmacdonald commented 9 years ago

Here we go:

Built-in Atom packages (77)
├── archive-view@0.37.0
├── atom-dark-syntax@0.19.0
├── atom-dark-ui@0.35.0
├── atom-light-syntax@0.20.0
├── atom-light-ui@0.30.0
├── autocomplete@0.32.0
├── autoflow@0.18.0
├── autosave@0.17.0
├── background-tips@0.16.0
├── base16-tomorrow-dark-theme@0.21.0
├── base16-tomorrow-light-theme@0.4.0
├── bookmarks@0.28.0
├── bracket-matcher@0.55.0 (disabled)
├── command-palette@0.24.0
├── deprecation-cop@0.10.0
├── dev-live-reload@0.34.0
├── exception-reporting@0.20.0
├── feedback@0.33.0
├── find-and-replace@0.138.0
├── fuzzy-finder@0.58.0
├── git-diff@0.39.0
├── go-to-line@0.25.0
├── grammar-selector@0.29.0
├── image-view@0.36.0
├── incompatible-packages@0.9.0
├── keybinding-resolver@0.20.0
├── language-c@0.28.0
├── language-coffee-script@0.30.0
├── language-css@0.17.0
├── language-gfm@0.50.0
├── language-git@0.9.0
├── language-go@0.17.0
├── language-html@0.26.0
├── language-hyperlink@0.12.0
├── language-java@0.11.0
├── language-javascript@0.39.0
├── language-json@0.8.0
├── language-less@0.15.0
├── language-make@0.12.0
├── language-mustache@0.10.0
├── language-objective-c@0.11.0
├── language-perl@0.9.0
├── language-php@0.16.0
├── language-property-list@0.7.0
├── language-python@0.19.0
├── language-ruby@0.37.0
├── language-ruby-on-rails@0.18.0
├── language-sass@0.21.0
├── language-shellscript@0.8.0
├── language-source@0.8.0
├── language-sql@0.10.0
├── language-text@0.6.0
├── language-todo@0.11.0
├── language-toml@0.12.0
├── language-xml@0.20.0
├── language-yaml@0.17.0
├── link@0.25.0
├── markdown-preview@0.102.0
├── metrics@0.34.0
├── open-on-github@0.30.0
├── package-generator@0.31.0
├── release-notes@0.36.0
├── settings-view@0.142.0
├── snippets@0.52.0
├── solarized-dark-syntax@0.22.0
├── solarized-light-syntax@0.12.0
├── spell-check@0.42.0
├── status-bar@0.44.0
├── styleguide@0.30.0
├── symbols-view@0.63.0
├── tabs@0.50.0
├── timecop@0.22.0
├── tree-view@0.125.0
├── update-package-dependencies@0.6.0
├── welcome@0.18.0
├── whitespace@0.25.0
└── wrap-guide@0.22.0

/Users/jmacdonald/.atom/packages (12)
├── close-all@0.1.0
├── easy-motion@1.1.0
├── file-switcher@0.0.0
├── git-plus@3.10.4
├── minimap@3.1.0
├── minimap-git-diff@2.0.1
├── rails-rspec@0.2.0
├── rspec@0.1.7
├── solarized-dark-ui@0.3.0
├── solarized-light-ui@0.1.0
├── theme-switcher@0.1.0
└── vim-mode@0.14.0
adrian-budau commented 9 years ago

I don't have enough time to install and check/uncheck all these plugins. Could you deactivate them all and activate them one by one until easy-motion starts moving slow? (I'm referring to those 12 packages).

jmacdonald commented 9 years ago

Turns out that it wasn't related to packages at all, but my keymap file. Really strange that it only affected easy-motion, but if I can isolate the problem, I'll report it to the atom project itself. :smile:

adrian-budau commented 9 years ago

It's great that you found the problem. Could you give me some insights into what the problem was once you isolate it? It'd be great to know.

jmacdonald commented 9 years ago

Definitely!