search

adrian-budau / easy-motion

Easy Motion for Atom IDE
MIT License
20 stars 4 forks source link

Unreadable with light colored themes #5

Closed crucialfelix closed 9 years ago

crucialfelix commented 9 years ago

Using Fizzy, unfortunately I can't read anything. Instead of 'yellow' and and $base-background-color you could use text-color-highlight, text-color-selected and the matching background colors

https://github.com/atom/atom-dark-ui/blob/master/stylesheets/ui-variables.less

screen shot 2014-09-24 at 10 54 33

adrian-budau commented 9 years ago

Fizzy for example doesn't set those variables. I pushed a change which calculates the color based on the background-color defined in syntax-variables.less (which is a standard way to define a syntax theme). Unfortunately fizzy doesn't define it so I tweaked it in such a way that it looks decent on both dark and light themes that do not define this file.

crucialfelix commented 9 years ago

Awesome, that should work. thanks !