adrian-ilie / av-sync

YouTube AV Sync Chrome Extension
GNU General Public License v3.0
61 stars 7 forks source link

Does not work anymore #16

Open Moris-Shalon opened 1 month ago

Moris-Shalon commented 1 month ago

As for me, it doesn't work anymore: not in Chrome and not in Firefox. Seems like there were some changes on YouTube side (or maybe in both browsers, i am not sure).

What, actually, happens: you can calibrate the sound delay/latency in extension's settings page. You can even enable and disable the extension from the button in the lower right corner on video (near settings, fullscreen, etc.). But adjusting delay/latency changes nothing (both from it's extension's settings page and from the button on video). Audio from video plays without any changes, it isn't affected at all, so this extension does not work as of now.

This is what I see in console:

image

Seems like this hack doesn't work anymore:

function generateHandler(name) {
  return function(
      id, notification_details, success_callback, failure_callback) {
    // Since we need to modify the details object, we copy it to avoid those
    // changes also being made to the object on the caller's side.
    // TODO(dewittj): Remove this hack. This is used as a way to deep
    // copy a complex JSON object.
    var notification_details_copy = $JSON.parse(
        $JSON.stringify(notification_details));
    replaceNotificationOptionURLs(notification_details_copy, function(success) {
      if (success) {
        bindingUtil.sendRequest(
            name, [id, notification_details_copy, success_callback], undefined);
        return;
      }
      failure_callback('Unable to download all specified images.');
    });
  };
}
d4rkchild commented 3 weeks ago

Same here, damn shame. Was a great plugin