search

adrian-thurston / colm

The Colm Programming Language
MIT License
164 stars 31 forks source link

Correct for cross-compiling #124

Closed Grommish closed 3 years ago

Grommish commented 3 years ago

This corrects for the inability to use AC_CHECK_FILES during cross compiling.

Signed-off-by: Donald Hoskins grommish@gmail.com

adrian-thurston commented 3 years ago

Hi @grommish, wondering if we should just always use AS_IF? I haven't dug into this issue, but it seems AC_CHECK_FILES should be for things that are not needed when cross compiling, since it is explicitly not supported. Feeling a bit confused about the actual intended purpose of AC_CHECK_FILES now.

Grommish commented 3 years ago

I honestly couldn't tell you, sir. I just know how I've always handled the file checks in the past when cross compiling (other people's code). It could be that the AC_CHECK_FILES is legacy and just rote usage to check for a file, or it may be something specific. I've seen other devs just ignore the check and hope for the best that it's actually there, but this seems like a compromise I can live with (and correct for) when I run into it.

On Sat, Jan 16, 2021, 6:50 PM Adrian Thurston notifications@github.com wrote:

Hi @Grommish https://github.com/Grommish, wondering if we should just always use AS_IF? I haven't dug into this issue, but it seems AC_CHECK_FILES should be for things that are not needed when cross compiling, since it is explicitly not supported. Feeling a bit confused about the actual intended purpose of AC_CHECK_FILES now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adrian-thurston/colm/pull/124#issuecomment-761699525, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBY6JVM3F5UZUTO6SMTNM3S2IQ3ZANCNFSM4VHU6YSQ .