search

adrian17 / Gallifreyan

http://adrian17.github.io/Gallifreyan/
MIT License
134 stars 49 forks source link

Allow manual deletion of the lines #4

Closed m-sche closed 8 years ago

m-sche commented 8 years ago

Adds a button 'delete line', which, when clicked, emphasises all endpoints of the lines. When the user clicks at one of the lines' endpoints, the line is deleted. If the user clicks somewhere else, the translator returns to it's normal state.

Sorry, I closed the original pull request accidentaly.

adrian17 commented 8 years ago

It would probably by slightly nicer if the mode was toggle-able (like the buttons in, say, Paint) instead of one-time, but this is also good and could be changed later.

m-sche commented 8 years ago

The issues you pointed out were fixed, toggleable button left for the future.

adrian17 commented 8 years ago

Thanks!

m-sche commented 8 years ago

What a shame that in 2016 we're forced to use a hyphen instead of a proper minus...

adrian17 commented 8 years ago

Fixed it, needed an additional HTML meta attribute for encoding.

m-sche commented 8 years ago

Great job! I've just noticed my browser displays a warning about "The character encoding of the HTML document was not declared..." :D