search

adrian17 / Gallifreyan

http://adrian17.github.io/Gallifreyan/
MIT License
134 stars 49 forks source link

Allow manual addition of the lines #5

Closed m-sche closed 8 years ago

m-sche commented 8 years ago

New button "add line" added. When clicked, it allows the user to place a first end of the new line (denoted by a big red dot). After that, the user can place the second end, which looks just like ordinary moving of the lines.

This is a first draft, any comments are appreciated.

adrian17 commented 8 years ago

Didn't have a chance to make a proper review or testing yet, but just a thought... why not just put the line on the main circle (as a diagonal at some angle) and let the user move it himself? I'm not saying it's a better way to do it nor am I forcing it - it feels simpler, but is probably worse from UX perspective.

I'll try your branch tomorrow and see how it looks like.

m-sche commented 8 years ago

Yes, that was the first version I did -- add a line with both ends at the main circle and let the user handle it. It felt a bit odd from the user perspective, so I did this more complicated version. Of course, there is this disadvantage of adding complexity to the code, and the need to correctly handle situations like "a user clicks on 'delete line' and than immediately on 'add line'". I am not against the simpler version, I may try to recreate it and post it in a separate pull request, and then we can compare them.

adrian17 commented 8 years ago

The UX is great.

The code looks okay, it feels a bit like a cheat (well, it is :D), but it's a smart way of making it work with the current system with very little code. It just needs the comments to explain it a bit better, see the notes.