search

adriana82 / jammming

0 stars 0 forks source link

SUMMARY #5

Open Default4152 opened 6 years ago

Default4152 commented 6 years ago

GRADE: MEETS EXPECTATIONS

This project is working great and very smoothly. I really like that you got it setup with surge. The code is generally clean and there are no gleaming errors. I liked your usage of .includes in the addTrack method. A couple things I would change is making sure you follow a style guide like airbnb to make sure you maintain consistency through your project (https://github.com/airbnb/javascript/tree/master/react). Another thing I would make sure you do is include all the essential files for a simple npm install and npm start - you were missing some important files like package.json and the public folder. Overall, excellent job.

adriana82 commented 6 years ago

Thank you , this definately helps a lot and i'll work more on improving in those areas.