search

adrianaisemberg / tapet_feedback

Feedback page for Tapet
2 stars 0 forks source link

Add support for Material You accent colors #4

Open doenietzomoeilijk opened 2 years ago

doenietzomoeilijk commented 2 years ago

I am in no way certain whether this is possible or not, but I would really like the Material You accent colors to be re-generated for each new Tapet wallpaper. As it is, I don't even see live wallpapers anymore, so maybe it's a limitation in Android 12 or Samsung OneUI.

Is this at all possible, or would it require hooks in Android that simply don't exist?

adrianaisemberg commented 2 years ago

The operating system should be aware of the changed wallpaper and adjuts Material You accordingly. If this doesn't happen it means the OS either has a bug or is not configured correctly. Tapet doesn't "trigger" any Material You feature but only applies a wallpaper.

What do you mean by "I don't even see live wallpapers anymore"? Tapet isn't a Live-Wallpaper app.

Regards, Adrian

On Sun, May 15, 2022 at 12:00 AM Max Roeleveld @.***> wrote:

I am in no way certain whether this is possible or not, but I would really like the Material You accent colors to be re-generated for each new Tapet wallpaper. As it is, I don't even see live wallpapers anymore, so maybe it's a limitation in Android 12 or Samsung OneUI.

Is this at all possible, or would it require hooks in Android that simply don't exist?

— Reply to this email directly, view it on GitHub https://github.com/adrianaisemberg/tapet_feedback/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRLBV6NS7JJCMCRTHD6LDVKCOKPANCNFSM5V6VIHSQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

doenietzomoeilijk commented 2 years ago

The operating system should be aware of the changed wallpaper and adjuts Material You accordingly. If this doesn't happen it means the OS either has a bug or is not configured correctly.

Looks like this bit of functionality is not working correctly in Samsung OneUI 4.1, then, that's unfortunate. Otherwise, it should all "just work", then? Right now, when Tapet generates and applies a new wallpaper (either timed or manually), the color palette setting doesn't pick up on the changed colors, it'll just keep showing whatever was sampled from the last time I manually set an image background.

I might try contacting Samsung, but somehow I don't think this is going to get fixed anytime soon. ;) Again, unfortunate, but I understand how that's a Samsung issue, not a Tapet issue.

What do you mean by "I don't even see live wallpapers anymore"? Tapet isn't a Live-Wallpaper app.

Oh, but unless I'm misremembering things, it used to be, right? If that's changed (and even if it didn't and it never was the case), at least that explains why I don't see it.

adrianaisemberg commented 2 years ago

There was an optional Live-Wallpaper setting in the old Tapet which its only purpose was to allow applying wallpapers to the lock-screen on devices which do not support that unless it is a live-wallpaper, for example - Samsung.

Does Tapet apply to the lock-screen on your device now?

doenietzomoeilijk commented 2 years ago

There was an optional Live-Wallpaper setting in the old Tapet which its only purpose was to allow applying wallpapers to the lock-screen on devices which do not support that unless it is a live-wallpaper, for example - Samsung.

Ah, see, that's what I was remembering, then. Mystery solved.

Does Tapet apply to the lock-screen on your device now?

It does indeed, both when I pick a wallpaper manually and when it happens on a timer, lockscreen-specific effects are applied properly as well. It's just Samsungs way of implementing Material You that seems to miss it completely. It looks like those pallettes are only generated when I pick a file from the Samsung settings screen itself.

If there's anything useful I could pick up by looking at logs or anything, let me know.