search

adrianbj / TracyDebugger

The ultimate debugging and development tool for ProcessWire
https://adrianbj.github.io/TracyDebugger/
GNU General Public License v2.0
87 stars 13 forks source link

v4.22.5 prevents ProcessPageList from catching WireException #59

Closed Toutouwai closed 3 years ago

Toutouwai commented 3 years ago

ProcessPageList throws a WireException when a page is moved to a position where it is not allowed. The exception messages are displayed in a JS alert.

TracyDebugger v4.22.4

2021-06-09_125431

TracyDebugger v4.22.5

2021-06-09_125527

adrianbj commented 3 years ago

Sorry @Toutouwai - the change in 22.5 that has caused this was at the suggestion of @ryancramerdesign to fix https://github.com/adrianbj/TracyDebugger/issues/58

As you'll see this goes back to a couple of issues that you posted about. Obviously what I / we came up with back then wasn't perfect, but it seems like this new approach isn't either. I've made another change which fixes this issue and seems not to break anything else, but I'd love if you could keep an eye on this and I'd also really appreciate it Ryan if you could maybe dive into this a little deeper to see if there is a better way to approach this.

Toutouwai commented 3 years ago

Thanks for the speedy fix. Will keep an eye out for any related issues.