search

adriancarriger / angularfire2-offline

🔌 A simple wrapper for AngularFire2 to read and write to Firebase while offline, even after a complete refresh.
https://angularfire2-offline.firebaseapp.com/
MIT License
207 stars 48 forks source link

Update to angularfire2 4.0.0rc0 #21

Closed rodrifmed closed 7 years ago

rodrifmed commented 7 years ago

Hi Adrian,

Do you have plans to upgrade your lib to work with angularfire2 4.0.0rc0?

My question is because on angularfire2 2.0.0-beta8 I can´t run ionic build android --prod, the build fails.

But on new angularfire2 version, this problem was fix.

Thanks,

adriancarriger commented 7 years ago

Hi @rodrifmed I would like this library to work with Angularfire2 4.x and I will be looking into supporting it. Thanks for posting the issue!

I'm wondering if your issue with running ionic build android --prod is related to issue #11?

rodrifmed commented 7 years ago

I didn't have problem with angularfire offline. Only with angularfire2.

I made some changes localy on your lib to run with angular2 4.0.0rc0 and works fine the aot compile!

The change is simply, only change AngularFire to AngularFireDatabase on imports and use af.database to only af.

rodrifmed commented 7 years ago

I have to change the index.metadata.json too

bergergit commented 7 years ago

+1 for this enhancement. This project looks awesome, and it would be great to see it working with latest version of angularfire2 :)

adriancarriger commented 7 years ago

🎉 This is now implemented in AngularFire2 Offline version 3.0.0

Also, here is an upgrade tutorial

bergergit commented 7 years ago

Just implemented the change and it worked perfectly! Both in Android (Ionic) and in Browser. Thanks so much for your effort. This project really improves user experience for any Firebase project. 🥇

adriancarriger commented 7 years ago

@bergergit Awesome, glad to hear that!